A status from one of Time's own workflows is not a check #125

Closed
opened 2026-10-18 04:58:23 +00:00 by teahubxyz · 2 comments
Owner

A seat's review (#116) is a pull_request_review event, which wakes heartbeat.yml while a heartbeat is already running; the concurrency group cancels the new run and Gitea records heartbeat / tick (pull_request_review): failure on the PR head. checks() read that as a failing check, so #120 and #121, approved by haiku with CI green, could not land, and every PR a seat reviews from inside a heartbeat would be stuck the same way.

  • checks() skips statuses whose context comes from Time's own workflows (heartbeat /, mention /, venture /, astra /, doctor /, update /, steward /): they say nothing about the code, so they neither block nor earn a merge. CI still decides.
  • Test 15a: a cancelled heartbeat status next to green CI merges; a green heartbeat status alone is "no checks" (CI gets dispatched); a pending mention run does not hold a merge.

PR: #124

DONE: PR open; python3 .github/time/test_time.py passes including 15a; CI green.

A seat's review (#116) is a `pull_request_review` event, which wakes `heartbeat.yml` while a heartbeat is already running; the concurrency group cancels the new run and Gitea records `heartbeat / tick (pull_request_review): failure` on the PR head. `checks()` read that as a failing check, so #120 and #121, approved by `haiku` with CI green, could not land, and every PR a seat reviews from inside a heartbeat would be stuck the same way. - `checks()` skips statuses whose context comes from Time's own workflows (`heartbeat /`, `mention /`, `venture /`, `astra /`, `doctor /`, `update /`, `steward /`): they say nothing about the code, so they neither block nor earn a merge. CI still decides. - Test 15a: a cancelled heartbeat status next to green CI merges; a green heartbeat status alone is "no checks" (CI gets dispatched); a pending mention run does not hold a merge. PR: #124 DONE: PR open; `python3 .github/time/test_time.py` passes including 15a; CI green.
teahubxyz added the ready label 2026-10-18 04:58:23 +00:00

⏱️ Time: adopted PR #124, built outside the worker. haiku reviewed it on the PR.

⏱️ Time: adopted PR #124, built outside the worker. `haiku` reviewed it on the PR. <!-- time {"beat":"pr","pr":124,"adopted":true,"launched":false,"review":"venice","seat":"haiku","as":"seat"} -->
time closed this issue 2026-10-18 05:15:05 +00:00

⏱️ Time: PR #124 merged. Card done.

⏱️ Time: PR #124 merged. Card done. <!-- time {"beat":"merged","pr":124} -->
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: teahubxyz/time#125