Housekeeping: a null page is an empty one #182

Merged
teahubxyz merged 4 commits from housekeeping-null-page into main 2026-10-19 13:47:24 +00:00
Owner

Today's 13:17 sweep (run 1151) failed in the signal step: TypeError: 'NoneType' object is not iterable. It was the first day a signal issue reached its 7-day measuring window, so the first time the sweep read an issue's reactions. Gitea answers an issue nobody reacted to with null, not [], and paged() did out += batch.

  • housekeeping.py: paged() takes a null page as empty.
  • test_housekeeping.py: the fake forge answers no reactions with null, as Gitea does. Without the fix test_signals fails exactly as production did; with it, all 6 pass.
  • CHANGELOG entry (placed so it doesn't cross #181's).

Branches and milestones were unaffected (9 branches pruned today). Tomorrow's sweep will close the signal issues past their window that have no signups.

🤖 Generated with Claude Code

https://claude.ai/code/session_017K4vyY3yUD3GsvoZaAtKkD

Today's 13:17 sweep (run 1151) failed in the signal step: `TypeError: 'NoneType' object is not iterable`. It was the first day a signal issue reached its 7-day measuring window, so the first time the sweep read an issue's reactions. Gitea answers an issue nobody reacted to with `null`, not `[]`, and `paged()` did `out += batch`. - `housekeeping.py`: `paged()` takes a null page as empty. - `test_housekeeping.py`: the fake forge answers no reactions with `null`, as Gitea does. Without the fix `test_signals` fails exactly as production did; with it, all 6 pass. - CHANGELOG entry (placed so it doesn't cross #181's). Branches and milestones were unaffected (9 branches pruned today). Tomorrow's sweep will close the signal issues past their window that have no signups. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_017K4vyY3yUD3GsvoZaAtKkD
teahubxyz added 4 commits 2026-10-19 13:44:17 +00:00
teahubxyz merged commit d235afb7f3 into main 2026-10-19 13:47:24 +00:00
Sign in to join this conversation.