Review: show the reviewer the PR's check statuses #52

Closed
opened 2026-10-14 20:30:37 +00:00 by teahubxyz · 3 comments
Owner

On #50 the reviewer objected that "tests green" wasn't shown, but CI was green on that commit. review() gives the reviewer the PR's title, body and diff, never the head commit's statuses, so it can't see evidence that already exists.

  • In review() (.github/time/time.py), add the head commit's statuses (each context and its state, from GET /repos/{repo}/commits/{sha}/status) to the reviewer's input under a # Checks heading, before the diff. A failed lookup adds "(checks unavailable)" and the review goes on.
  • In the reviewer's rules, say that the checks listed there are evidence it can rely on, and that pending checks are not yet evidence.
  • Add a check in test_time.py that the reviewer's input contains the statuses.

Depends on #51

DONE: PR open; the new check passes; CI green.

On #50 the reviewer objected that "tests green" wasn't shown, but CI was green on that commit. `review()` gives the reviewer the PR's title, body and diff, never the head commit's statuses, so it can't see evidence that already exists. - In `review()` (`.github/time/time.py`), add the head commit's statuses (each `context` and its state, from `GET /repos/{repo}/commits/{sha}/status`) to the reviewer's input under a `# Checks` heading, before the diff. A failed lookup adds "(checks unavailable)" and the review goes on. - In the reviewer's rules, say that the checks listed there are evidence it can rely on, and that pending checks are not yet evidence. - Add a check in `test_time.py` that the reviewer's input contains the statuses. Depends on #51 DONE: PR open; the new check passes; CI green.
teahubxyz added the queued label 2026-10-14 20:30:37 +00:00
time added ready and removed queued labels 2026-10-14 21:18:07 +00:00

⏱️ Time: Claude Sonnet (Anthropic) is working on this now, on branch time/card-52.

⏱️ Time: Claude Sonnet (Anthropic) is working on this now, on branch `time/card-52`. <!-- time {"beat":"dispatched","launched":true,"worker":"anthropic"} -->

⏱️ Time: sonnet opened PR #56 (10 steps, claude-sonnet-5-5). Review and landing follow on the next beat.

⏱️ Time: `sonnet` opened PR #56 (10 steps, claude-sonnet-5-5). Review and landing follow on the next beat. <!-- time {"beat":"dispatched","worker":"anthropic","pr":56,"steps":10,"seat":"sonnet","model":"claude-sonnet-5-5"} -->

⏱️ Time: PR #56 is up for this card. haiku reviewed it on the PR.

⏱️ Time: PR #56 is up for this card. `haiku` reviewed it on the PR. <!-- time {"beat":"pr","pr":56,"launched":false,"review":"venice","seat":"haiku"} -->
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: teahubxyz/time#52