The reviewer's rule says a success under # Checks "means those tests or builds passed". A commit status can come from any integration, so say instead that a success means that context reported success.
PR bodies end up with Closes #N twice: the worker writes it in its summary, and open_pr adds it again. Have open_pr add the line only when the summary doesn't already contain Closes #N for this card.
Two small things from the review of #56:
- The reviewer's rule says a success under `# Checks` "means those tests or builds passed". A commit status can come from any integration, so say instead that a success means that context reported success.
- PR bodies end up with `Closes #N` twice: the worker writes it in its summary, and `open_pr` adds it again. Have `open_pr` add the line only when the summary doesn't already contain `Closes #N` for this card.
- Checks in `.github/time/test_time.py` for both.
Depends on #53
DONE: PR open; the new checks pass; CI green.
⏱️ Time: Claude Sonnet (Anthropic) is working on this now, on branch time/card-58.
⏱️ Time: Claude Sonnet (Anthropic) is working on this now, on branch `time/card-58`.
<!-- time {"beat":"dispatched","launched":true,"worker":"anthropic"} -->
⏱️ Time: sonnet opened PR #74 (8 steps, claude-sonnet-5-5). Review and landing follow on the next beat.
⏱️ Time: `sonnet` opened PR #74 (8 steps, claude-sonnet-5-5). Review and landing follow on the next beat.
<!-- time {"beat":"dispatched","worker":"anthropic","pr":74,"steps":8,"seat":"sonnet","model":"claude-sonnet-5-5"} -->
⏱️ Time: PR #74 is up for this card. haiku reviewed it on the PR.
⏱️ Time: PR #74 is up for this card. `haiku` reviewed it on the PR.
<!-- time {"beat":"pr","pr":74,"launched":false,"review":"venice","seat":"haiku"} -->
⏱️ Time: approved, but PR #74 touches protected paths (.github/time/test_time.py, .github/time/time.py), so a human merges this one.
⏱️ Time: approved, but PR #74 touches protected paths (.github/time/test_time.py, .github/time/time.py), so a human merges this one.
<!-- time {"beat":"needs-human","pr":74} -->
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Two small things from the review of #56:
# Checks"means those tests or builds passed". A commit status can come from any integration, so say instead that a success means that context reported success.Closes #Ntwice: the worker writes it in its summary, andopen_pradds it again. Haveopen_pradd the line only when the summary doesn't already containCloses #Nfor this card..github/time/test_time.pyfor both.Depends on #53
DONE: PR open; the new checks pass; CI green.
⏱️ Time: Claude Sonnet (Anthropic) is working on this now, on branch
time/card-58.⏱️ Time:
sonnetopened PR #74 (8 steps, claude-sonnet-5-5). Review and landing follow on the next beat.⏱️ Time: PR #74 is up for this card.
haikureviewed it on the PR.⏱️ Time: approved, but PR #74 touches protected paths (.github/time/test_time.py, .github/time/time.py), so a human merges this one.