Accept existing PR #75: overlapping API workers with contention recovery #84

Open
opened 2026-10-18 01:04:49 +00:00 by teahubxyz · 2 comments
Owner

Code acceptance/landing card for the existing PR #75 (chatgpt/parallel-api), part of #68. The implementation already exists: do not start another build or create a replacement PR.

Depends on #123
(#75 is mergeable: false against current main: tick(), review(), budget_check() and chat() all moved since it was cut. #123 brings a PR branch that fell behind its base up to date and hands a conflict to the worker as a revision; until it lands, adopting #75 can only end at a human.)

Current candidate: 15f6e39164. Landed engine changes from #74 and #81 have been reconciled into its source and tests. A combined-tree rehearsal against main 4f8eda2483 passed on Fly. The existing MCP does not expose branch rebase/update, so published Git history is preserved rather than force-rewritten; verify the effective diff against current main before landing.

Independent read-only Codex/Sol review on teahub-runtime initially objected to temporary budget contention stranding dispatched cards. Fixed: wait for outstanding reservations, resume automatically, replace reservation and usage atomically, and use event-synchronized regression tests. A second independent gpt-6.1-sol high review approved the resulting source. These are external CLI review receipts, not yet a Gitea review signed by sol. CI #665 is green and its log explicitly confirms the new tests ran.

Required code acceptance: review the current head via an authorized independent reviewer route; confirm CI executed API overlap, contention recovery, hard-cap rejection and failure cleanup; land under the normal review/check policy. No permission or spending expansion. No Mac placement.

Registration note: the current heartbeat starts a builder for an uninitialized ready card even when a linked PR already exists. This review-only card is therefore intentionally not marked ready, to avoid a duplicate implementation. It is available to the existing reviewer/landing route or the forthcoming non-card-PR landing extension.

After merge, record a bounded live API-overlap smoke under #68 with timestamps, output receipts and actual usage. Closing this code card does not by itself establish live throughput or finish #68/#79.

DONE: Existing PR #75 is independently accepted and merged with current-head CI evidence, without a duplicate implementation.

Code acceptance/landing card for the existing PR #75 (chatgpt/parallel-api), part of #68. The implementation already exists: do not start another build or create a replacement PR. Depends on #123 (#75 is `mergeable: false` against current main: `tick()`, `review()`, `budget_check()` and `chat()` all moved since it was cut. #123 brings a PR branch that fell behind its base up to date and hands a conflict to the worker as a revision; until it lands, adopting #75 can only end at a human.) Current candidate: 15f6e3916432. Landed engine changes from #74 and #81 have been reconciled into its source and tests. A combined-tree rehearsal against main 4f8eda2483bb passed on Fly. The existing MCP does not expose branch rebase/update, so published Git history is preserved rather than force-rewritten; verify the effective diff against current main before landing. Independent read-only Codex/Sol review on teahub-runtime initially objected to temporary budget contention stranding dispatched cards. Fixed: wait for outstanding reservations, resume automatically, replace reservation and usage atomically, and use event-synchronized regression tests. A second independent gpt-6.1-sol high review approved the resulting source. These are external CLI review receipts, not yet a Gitea review signed by sol. CI #665 is green and its log explicitly confirms the new tests ran. Required code acceptance: review the current head via an authorized independent reviewer route; confirm CI executed API overlap, contention recovery, hard-cap rejection and failure cleanup; land under the normal review/check policy. No permission or spending expansion. No Mac placement. Registration note: the current heartbeat starts a builder for an uninitialized ready card even when a linked PR already exists. This review-only card is therefore intentionally not marked ready, to avoid a duplicate implementation. It is available to the existing reviewer/landing route or the forthcoming non-card-PR landing extension. After merge, record a bounded live API-overlap smoke under #68 with timestamps, output receipts and actual usage. Closing this code card does not by itself establish live throughput or finish #68/#79. DONE: Existing PR #75 is independently accepted and merged with current-head CI evidence, without a duplicate implementation.
teahubxyz referenced this issue from a commit 2026-10-19 13:48:28 +00:00
time added the queued label 2026-10-19 13:50:27 +00:00
time added ready and removed queued labels 2026-10-19 15:11:53 +00:00

⏱️ Time: adopted PR #75, built outside the worker. haiku reviewed it on the PR.

⏱️ Time: adopted PR #75, built outside the worker. `haiku` reviewed it on the PR. <!-- time {"beat":"pr","pr":75,"adopted":true,"launched":false,"seat":"haiku","as":"seat","review":"venice","seats":["haiku"]} -->

⏱️ Time: the reviewer objected on PR #75. Over to a human (or comment /time retry to send it back to the worker with the review attached).

⏱️ Time: the reviewer objected on PR #75. Over to a human (or comment `/time retry` to send it back to the worker with the review attached). <!-- time {"beat":"needs-human","pr":75} -->
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: teahubxyz/time#84