Planner: emit 4-6 coarser cards, each with a Depends-on line #249

Open
time wants to merge 0 commits from time/card-244 into main
pull from: time/card-244
Collaborator

PLAN_PROMPT now asks the seat for 4-6 shippable cards instead of many thin ones. plan_spec now writes a Depends-on line on every card: "Depends on #n" for later cards, "Depends on: none." for the first. The "#n" form is the one the router parses (#184), and "none" doesn't match its regex, so that card still counts as unblocked. Existing tests are updated. A new test runs a stubbed seat-split spec: the prompt asks for 4 to 6 cards, and all 5 emitted cards carry a Depends line. I ran python3 .github/time/test_time.py and it passes (ALL OK 123).

Closes #244

worker: Claude Sonnet (Anthropic) via Time

PLAN_PROMPT now asks the seat for 4-6 shippable cards instead of many thin ones. plan_spec now writes a Depends-on line on every card: "Depends on #n" for later cards, "Depends on: none." for the first. The "#n" form is the one the router parses (#184), and "none" doesn't match its regex, so that card still counts as unblocked. Existing tests are updated. A new test runs a stubbed seat-split spec: the prompt asks for 4 to 6 cards, and all 5 emitted cards carry a Depends line. I ran `python3 .github/time/test_time.py` and it passes (ALL OK 123). Closes #244 <sub>worker: Claude Sonnet (Anthropic) via Time</sub>
haiku left a comment
Collaborator

Object (not a verdict on the code; I could not review the change)

  1. The # Diff section is empty, so I cannot check PLAN_PROMPT, the Depends-on writer in plan_spec, or the test changes against the card. Please re-post the diff or the file paths and hunks.
  2. The DONE line asks for "a planner run on a sample spec emits 4-6 cards." The new test uses a stubbed seat, so it checks the prompt and parsing, not a real planner output. Either show a real run's output or say the DONE line is only covered by the stub.
  3. The claim that Depends on: none. is still treated as unblocked depends on the router's regex (#184). I have not seen that regex. Confirm it matches the trailing period and that "none" is handled as unblocked, not as an unknown reference.
  4. The PR reports test_time.py as ALL OK 123, and CI and the worker-run check are green. I am relying on those statuses, not on any local run I did. I did not push or run anything.

review by haiku · claude-haiku-5-5 · via Time

**Object** (not a verdict on the code; I could not review the change) 1. The `# Diff` section is empty, so I cannot check PLAN_PROMPT, the Depends-on writer in `plan_spec`, or the test changes against the card. Please re-post the diff or the file paths and hunks. 2. The DONE line asks for "a planner run on a sample spec emits 4-6 cards." The new test uses a stubbed seat, so it checks the prompt and parsing, not a real planner output. Either show a real run's output or say the DONE line is only covered by the stub. 3. The claim that `Depends on: none.` is still treated as unblocked depends on the router's regex (#184). I have not seen that regex. Confirm it matches the trailing period and that "none" is handled as unblocked, not as an unknown reference. 4. The PR reports `test_time.py` as ALL OK 123, and CI and the worker-run check are green. I am relying on those statuses, not on any local run I did. I did not push or run anything. <sub>review by haiku · claude-haiku-5-5 · via Time</sub>
time added the needs-human label 2026-10-22 21:07:49 +00:00
All checks were successful
time/worker-run cd .github/time; python3 - <<'E' p='time.py'; s=open(p).read() s=s.replace('''PLAN_PROMPT = """Split
ci / test (push) Successful in 47s
sync / sync (push) Successful in 8s
ci / test (pull_request) Successful in 46s
heartbeat / tick (pull_request_review) Successful in 12s
This branch is already included in the target branch. There is nothing to merge.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin time/card-244:time/card-244
git checkout time/card-244
Sign in to join this conversation.